fix: incorrect error handling in org id default function

[PeterSchafer]

No description provided.

[snyk-io]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

✅ code/snyk check is complete. No issues have been found. (View Details)

[snyk-io]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

✅ code/snyk check is complete. No issues have been found. (View Details)

[cursor]

Bug: Error Swallowing in `defaultFuncOrganizationSlug`

The defaultFuncOrganizationSlug function incorrectly swallows errors. It logs internal errors (e.g., from API calls like GetSlugFromOrgId()) but then returns nil instead of propagating them. This behavior is inconsistent with defaultFuncOrganization (which was recently fixed to propagate errors) and prevents ORGANIZATION_SLUG from returning an error via GetStringWithError when expected. This causes Test_initConfiguration_failDefaultOrgLookup to fail.

pkg/app/app_test.go#L198-L201

go-application-framework/pkg/app/app_test.go

Lines 198 to 201 in 71c02df

	actualOrgSlug, slugError := config.GetStringWithError(configuration.ORGANIZATION_SLUG)
	assert.Error(t, slugError)
	assert.Empty(t, actualOrgSlug)

pkg/app/app.go#L44-L48

go-application-framework/pkg/app/app.go

Lines 44 to 48 in 71c02df

	return slugName, nil
	}
	return callback
	}

---