Open
Conversation
Collaborator
|
Hey @omercnet |
mcombuechen
reviewed
Jul 15, 2025
Comment on lines
+7
to
+10
| enricher: | ||
| description: "Enricher to use" | ||
| required: false | ||
| default: "ecosystems" |
Collaborator
There was a problem hiding this comment.
Can we rather make this a choice and remain neutral on the default? Ideally we want consumers to be explicit about the enrichment strategy. I'm thinking something like:
Suggested change
| enricher: | |
| description: "Enricher to use" | |
| required: false | |
| default: "ecosystems" | |
| enricher: | |
| description: "Enricher to use" | |
| required: true | |
| type: choice | |
| options: | |
| - ecosystems | |
| - snyk |
What do you think?
| version: | ||
| description: "Parlay version (default: latest)" | ||
| required: false | ||
| token: |
Collaborator
There was a problem hiding this comment.
To enrich with snyk, we'd also need an interface to pass a Snyk API token, which is a hard requirement. Can we extend the inputs with an option to do this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9