Skip to content

feat(secrets): persist and run Secrets with other scanners [IDE-1747] #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acke merged 9 commits into from
Feb 27, 2026
Merged

feat(secrets): persist and run Secrets with other scanners [IDE-1747] #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ead0e7b
feat(secrets): persist and run Secrets with other scanners [IDE-1747]
acke Feb 25, 2026
22b6ef6
feat(ui): add Secrets root to tool window tree and fix clean-all [IDE…
acke Feb 25, 2026
0dd3ccb
fix(ui): show Secrets in HTML tree view on first load [IDE-1747]
acke Feb 25, 2026
4dac786
refactor(toolwindow): remove Secrets from native tree [IDE-1747]
acke Feb 27, 2026
71379e6
chore(toolwindow): remove SECRETS_ROOT_TEXT, add Secrets description …
acke Feb 27, 2026
9590e28
refactor(toolwindow): remove Secrets from tree filter and HTML tree […
acke Feb 27, 2026
3d72b07
refactor(toolwindow): remove unused secrets count from tree presentat…
acke Feb 27, 2026
b92f544
refactor(toolwindow): remove redundant SECRETS branches for PR review…
acke Feb 27, 2026
1f8da13
Merge branch 'master' into feat/IDE-1747-secrets-scanner
acke Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/kotlin/io/snyk/plugin/ui/jcef/ConfigurationDataClasses.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ data class SaveConfigRequest(
@SerializedName("activateSnykOpenSource") val activateSnykOpenSource: Boolean? = null,
@SerializedName("activateSnykCode") val activateSnykCode: Boolean? = null,
@SerializedName("activateSnykIac") val activateSnykIac: Boolean? = null,
@SerializedName("activateSnykSecrets") val activateSnykSecrets: Boolean? = null,
@SerializedName("scanningMode") val scanningMode: String? = null,

// Connection Settings
Expand Down
1 change: 1 addition & 0 deletions src/main/kotlin/io/snyk/plugin/ui/jcef/SaveConfigHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ class SaveConfigHandler(
settings.ossScanEnable = config.activateSnykOpenSource ?: false
settings.snykCodeSecurityIssuesScanEnable = config.activateSnykCode ?: false
settings.iacScanEnabled = config.activateSnykIac ?: false
settings.secretsEnabled = config.activateSnykSecrets ?: false

// Scanning mode
config.scanningMode?.let { settings.scanOnSave = (it == "auto") }
Expand Down
6 changes: 2 additions & 4 deletions src/main/kotlin/io/snyk/plugin/ui/toolwindow/SnykToolWindowPanel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,9 +385,7 @@ class SnykToolWindowPanel(val project: Project) : JPanel(), Disposable {
ScanIssue.CODE_SECURITY -> cache?.currentSnykCodeResultsLS
ScanIssue.OPEN_SOURCE -> cache?.currentOSSResultsLS
ScanIssue.INFRASTRUCTURE_AS_CODE -> cache?.currentIacResultsLS
else -> {
null
}
else -> null
}
productIssues?.values?.any { issues -> issues.any { issue.id == it.id } } == true
} else {
Expand Down Expand Up @@ -538,7 +536,7 @@ class SnykToolWindowPanel(val project: Project) : JPanel(), Disposable {
scanListenerLS.displayIacResults(results)
}
}
LsProduct.Secrets -> Unit // we use the HTML tree for secrets
LsProduct.Secrets -> Unit
LsProduct.Unknown -> Unit
}
}
Expand Down
1 change: 1 addition & 0 deletions src/main/kotlin/snyk/common/lsp/LanguageServerWrapper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,7 @@ class LanguageServerWrapper(private val project: Project) : Disposable {
activateSnykOpenSource = ps.ossScanEnable.toString(),
activateSnykCodeSecurity = ps.snykCodeSecurityIssuesScanEnable.toString(),
activateSnykIac = ps.iacScanEnabled.toString(),
activateSnykSecrets = ps.secretsEnabled.toString(),
organization = ps.organization ?: "",
insecure = ps.ignoreUnknownCA.toString(),
endpoint = getEndpointUrl(),
Expand Down
1 change: 1 addition & 0 deletions src/main/kotlin/snyk/common/lsp/settings/LanguageServerSettings.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ data class LanguageServerSettings(
@SerializedName("activateSnykOpenSource") val activateSnykOpenSource: String? = "false",
@SerializedName("activateSnykCode") val activateSnykCode: String? = "false",
@SerializedName("activateSnykIac") val activateSnykIac: String? = "false",
@SerializedName("activateSnykSecrets") val activateSnykSecrets: String? = "false",
@SerializedName("insecure") val insecure: String?,
@SerializedName("endpoint") val endpoint: String?,
@SerializedName("additionalParams") val additionalParams: String? = null,
Expand Down
Loading