hotfix: 1.1298.2 #941
hotfix: 1.1298.2 #941
Conversation
* chore: update snyk_trust description * fix: ignore trust if trusted
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ShawkyZ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request merges a hotfix back to the main branch, focusing on improving the robustness of the Snyk integration. It introduces a safeguard to prevent unnecessary trust operations for folders that are already trusted and clarifies the usage descriptions for certain Snyk tools.
Highlights
- Snyk Trust Handling Improvement: The
snyk_trusttool's handler (snykTrustHandler) now includes a check to determine if a given folder is already trusted. Ifm.folderTrust.IsFolderTrusted(folderPath)returns true, the tool will log an informational message and return a result indicating that the folder is already trusted, thereby preventing redundant trust operations. - Snyk Tool Description Updates: The
snyk_tools.jsonfile has been updated to refine the descriptions for two Snyk tools:snyk_sca_scanandsnyk_trust. Thesnyk_sca_scandescription's 'How to use' section was simplified, and thesnyk_trustdescription now includes a warning to only run the tool if instructed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request merges a hotfix that improves the snyk_trust tool. It now avoids asking for trust for already trusted folders and updates tool descriptions in the configuration. The code changes are correct. I've added one suggestion to improve logging by using a structured format, which will enhance observability.
| @@ -218,6 +218,12 @@ func (m *McpLLMBinding) snykTrustHandler(invocationCtx workflow.InvocationContex | |||
| return nil, fmt.Errorf("empty path given to tool %s", toolDef.Name) | |||
| } | |||
|
|
|||
| if m.folderTrust.IsFolderTrusted(folderPath) { | |||
| msg := fmt.Sprintf("Folder '%s' is already trusted", folderPath) | |||
| logger.Info().Msg(msg) | |||
There was a problem hiding this comment.
To improve observability and align with best practices seen elsewhere in the codebase, it's better to use structured logging. By logging folderPath as a separate field, the logs become more easily searchable and parsable.
| logger.Info().Msg(msg) | |
| logger.Info().Str("folderPath", folderPath).Msg("Folder is already trusted") |
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
make generate)make lint-fix)