feat: [CLI-194] hardening subprocess logic

[dotkas]

• Ready for review
• Follows CONTRIBUTING rules
• Reviewed by Snyk internal team

What does this PR do?

Adds some extra hardening of the subprocess logic and adds better practices of not spawning things in a shell where avoidable.

Where should the reviewer start?

The subprocess file.

How should this be manually tested?

Basically as stated in the previous PR.

Any background context you want to provide?

Earlier we added a larger changeset that bumped shescape and handled the breaking changes this entailed. In the mean time we've become a bit wiser on how this works, and thus this PR adds more security hardening of the logic that spawns the subprocesses.

What are the relevant tickets?

https://snyksec.atlassian.net/browse/CLI-1049

Screenshots

N/A

Additional questions

I don't think the failing tests are my PR. All other PRs in the list (like this) sees the same failures.

[snyk-io]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

✅ code/snyk check is complete. No issues have been found. (View Details)