-
Notifications
You must be signed in to change notification settings - Fork 33
[Snyk] Security upgrade glob from 9.3.5 to 11.0.3 #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-BRACEEXPANSION-9789073
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @michelkaporin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, automatically generated by Snyk, updates the glob
dependency to a newer major version (11.0.3
) to fix a security vulnerability. This update involves significant changes to the dependency tree as reflected in the lock file and is flagged as a potentially breaking change.
Highlights
- Security Upgrade: Upgraded the
glob
package from version9.3.5
to11.0.3
to address a low severity Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-BRACEEXPANSION-9789073). - Major Version Bump: This is a major version upgrade for
glob
, which may introduce breaking changes. Reviewers should verify compatibility. - Dependency Tree Changes: The upgrade of
glob
and its dependencies (minimatch
,minipass
,path-scurry
, etc.) has resulted in significant changes to thepackage-lock.json
file, including the addition of new transitive dependencies.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades the glob
dependency from version 9.3.5 to 11.0.3 to address a Regular Expression Denial of Service (ReDoS) vulnerability. This is a significant version bump and introduces several changes in the dependency tree, including an increased minimum Node.js version requirement. While fixing the security vulnerability is important, the breaking changes and potential Node.js version incompatibility should be carefully reviewed and tested.
"engines": { | ||
"node": "20 || >=22" | ||
} | ||
}, | ||
"node_modules/@isaacs/cliui": { | ||
"version": "8.0.2", | ||
"resolved": "https://registry.npmjs.org/@isaacs/cliui/-/cliui-8.0.2.tgz", | ||
"integrity": "sha512-O8jcjabXaleOG9DQ0+ARXWZBTfnP4WNAqzuiJK7ll44AmxGKv/J2M4TPjxjY3znBCfvBXFzucm1twdyFybFqEA==", | ||
"license": "ISC", | ||
"dependencies": { | ||
"string-width": "^5.1.2", | ||
"string-width-cjs": "npm:string-width@^4.2.0", | ||
"strip-ansi": "^7.0.1", | ||
"strip-ansi-cjs": "npm:strip-ansi@^6.0.1", | ||
"wrap-ansi": "^8.1.0", | ||
"wrap-ansi-cjs": "npm:wrap-ansi@^7.0.0" | ||
}, | ||
"engines": { | ||
"node": ">=12" | ||
} | ||
}, | ||
"node_modules/@isaacs/cliui/node_modules/ansi-regex": { | ||
"version": "6.1.0", | ||
"resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-6.1.0.tgz", | ||
"integrity": "sha512-7HSX4QQb4CspciLpVFwyRe79O3xsIZDDLER21kERQ71oaPodF8jL725AgJMFAYbooIqolJoRLuM81SpeUkpkvA==", | ||
"license": "MIT", | ||
"engines": { | ||
"node": ">=12" | ||
}, | ||
"funding": { | ||
"url": "https://github.com/chalk/ansi-regex?sponsor=1" | ||
} | ||
}, | ||
"node_modules/@isaacs/cliui/node_modules/ansi-styles": { | ||
"version": "6.2.1", | ||
"resolved": "https://registry.npmjs.org/ansi-styles/-/ansi-styles-6.2.1.tgz", | ||
"integrity": "sha512-bN798gFfQX+viw3R7yrGWRqnrN2oRkEkUjjl4JNn4E8GxxbjtG3FbrEIIY3l8/hrwUwIeCZvi4QuOTP4MErVug==", | ||
"license": "MIT", | ||
"engines": { | ||
"node": ">=12" | ||
}, | ||
"funding": { | ||
"url": "https://github.com/chalk/ansi-styles?sponsor=1" | ||
} | ||
}, | ||
"node_modules/@isaacs/cliui/node_modules/emoji-regex": { | ||
"version": "9.2.2", | ||
"resolved": "https://registry.npmjs.org/emoji-regex/-/emoji-regex-9.2.2.tgz", | ||
"integrity": "sha512-L18DaJsXSUk2+42pv8mLs5jJT2hqFkFE4j21wOmgbUqsZ2hL72NsUU785g9RXgo3s0ZNgVl42TiHp3ZtOv/Vyg==", | ||
"license": "MIT" | ||
}, | ||
"node_modules/@isaacs/cliui/node_modules/string-width": { | ||
"version": "5.1.2", | ||
"resolved": "https://registry.npmjs.org/string-width/-/string-width-5.1.2.tgz", | ||
"integrity": "sha512-HnLOCR3vjcY8beoNLtcjZ5/nxn2afmME6lhrDrebokqMap+XbeW8n9TXpPDOqdGK5qcI3oT0GKTW6wC7EMiVqA==", | ||
"license": "MIT", | ||
"dependencies": { | ||
"eastasianwidth": "^0.2.0", | ||
"emoji-regex": "^9.2.2", | ||
"strip-ansi": "^7.0.1" | ||
}, | ||
"engines": { | ||
"node": ">=12" | ||
}, | ||
"funding": { | ||
"url": "https://github.com/sponsors/sindresorhus" | ||
} | ||
}, | ||
"node_modules/@isaacs/cliui/node_modules/strip-ansi": { | ||
"version": "7.1.0", | ||
"resolved": "https://registry.npmjs.org/strip-ansi/-/strip-ansi-7.1.0.tgz", | ||
"integrity": "sha512-iq6eVVI64nQQTRYq2KtEg2d2uU7LElhTJwsH4YzIHZshxlgZms/wIc4VoDQTlG/IvVIrBKG06CrZnp0qv7hkcQ==", | ||
"license": "MIT", | ||
"dependencies": { | ||
"ansi-regex": "^6.0.1" | ||
}, | ||
"engines": { | ||
"node": ">=12" | ||
}, | ||
"funding": { | ||
"url": "https://github.com/chalk/strip-ansi?sponsor=1" | ||
} | ||
}, | ||
"node_modules/@isaacs/cliui/node_modules/wrap-ansi": { | ||
"version": "8.1.0", | ||
"resolved": "https://registry.npmjs.org/wrap-ansi/-/wrap-ansi-8.1.0.tgz", | ||
"integrity": "sha512-si7QWI6zUMq56bESFvagtmzMdGOtoxfR+Sez11Mobfc7tm+VkUckk9bW2UeffTGVUbOksxmSw0AA2gs8g71NCQ==", | ||
"license": "MIT", | ||
"dependencies": { | ||
"ansi-styles": "^6.1.0", | ||
"string-width": "^5.0.1", | ||
"strip-ansi": "^7.0.1" | ||
}, | ||
"engines": { | ||
"node": ">=12" | ||
}, | ||
"funding": { | ||
"url": "https://github.com/chalk/wrap-ansi?sponsor=1" | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade introduces several new top-level dependencies in the node_modules
section, such as @isaacs/balanced-match
, @isaacs/brace-expansion
, @isaacs/cliui
, foreground-child
, jackspeak
, lru-cache
, package-json-from-dist
, path-scurry
, string-width-cjs
, strip-ansi-cjs
, and wrap-ansi-cjs
. This is expected with a major version bump and changes in the dependency tree. Reviewing the purpose and potential impact of these new dependencies is good practice.
"version": "5.0.1", | ||
"resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-5.0.1.tgz", | ||
"integrity": "sha512-quJQXlTSUGL2LH9SUXo8VwsY4soanhgo6LNSm84E1LBcE8s3O0wpdiRzyR9z/ZZJMlMWv37qOOb9pdJlMUEKFQ==", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"node_modules/cross-spawn": { | ||
"version": "7.0.3", | ||
"resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.3.tgz", | ||
"integrity": "sha512-iRDPJKUPVEND7dHPO8rkbOnPpyDygcDFtWjpeWNCgy8WP2rXcxXL8TskReQl6OrB2G7+UJrags1q15Fudc7G6w==", | ||
"dev": true, | ||
"version": "7.0.6", | ||
"resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.6.tgz", | ||
"integrity": "sha512-uV2QOWP2nWzsy2aMp8aRibhi9dlzF5Hgh5SHaB9OiTGEyDTiJJyx0uy51QXdyWbtAHNua4XJzUKca3OzKUd3vA==", | ||
"license": "MIT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"node_modules/eastasianwidth": { | ||
"version": "0.2.0", | ||
"resolved": "https://registry.npmjs.org/eastasianwidth/-/eastasianwidth-0.2.0.tgz", | ||
"integrity": "sha512-I88TYZWc9XiYHRQ4/3c5rjjfgkjhLyW2luGIheGERbNQ6OY7yTybanSpDXZa8y7VUP9YmDcYa+eyq4ca7iLqWA==", | ||
"dev": true | ||
"integrity": "sha512-I88TYZWc9XiYHRQ4/3c5rjjfgkjhLyW2luGIheGERbNQ6OY7yTybanSpDXZa8y7VUP9YmDcYa+eyq4ca7iLqWA==" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"node_modules/emoji-regex": { | ||
"version": "8.0.0", | ||
"resolved": "https://registry.npmjs.org/emoji-regex/-/emoji-regex-8.0.0.tgz", | ||
"integrity": "sha512-MSjYzcWNOA0ewAHpz0MxpYFvwg6yjy1NG3xteoqz644VCo/RPgnr1/GGt+ic3iJTzQ8Eu3TdM14SawnVUmGE6A==", | ||
"dev": true | ||
"integrity": "sha512-MSjYzcWNOA0ewAHpz0MxpYFvwg6yjy1NG3xteoqz644VCo/RPgnr1/GGt+ic3iJTzQ8Eu3TdM14SawnVUmGE6A==" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version": "3.0.0", | ||
"resolved": "https://registry.npmjs.org/shebang-regex/-/shebang-regex-3.0.0.tgz", | ||
"integrity": "sha512-7++dFhtcx3353uBaq8DDR4NuxBetBzC7ZQOhmTQInHEd6bSrXdiEyzCvG07Z44UYdLShWUyXt5M/yhz8ekcb1A==", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version": "4.2.2", | ||
"resolved": "https://registry.npmjs.org/string-width/-/string-width-4.2.2.tgz", | ||
"integrity": "sha512-XBJbT3N4JhVumXE0eoLU9DCjcaF92KLNqTmFCnG1pf8duUxFGwtP6AD6nkjw9a3IdiRtL3E2w3JDiE/xi3vOeA==", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version": "6.0.1", | ||
"resolved": "https://registry.npmjs.org/strip-ansi/-/strip-ansi-6.0.1.tgz", | ||
"integrity": "sha512-Y38VPSHcqkFrCpFnQ9vuSXmquuv5oXOKpGeT6aGrr3o3Gc9AlVa6JBfUSOCnbxGGZF+/0ooI7KrPuUSztUdU5A==", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version": "2.0.2", | ||
"resolved": "https://registry.npmjs.org/which/-/which-2.0.2.tgz", | ||
"integrity": "sha512-BLI3Tl1TW3Pvl70l3yq3Y64i+awpwXqsGBYWkkqMtnbXgrMD+yj7rhW0kuEDxzJaYXGjEW5ogapKNMEKNMjibA==", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ansi-regex": { | ||
"version": "5.0.1", | ||
"resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-5.0.1.tgz", | ||
"integrity": "sha512-quJQXlTSUGL2LH9SUXo8VwsY4soanhgo6LNSm84E1LBcE8s3O0wpdiRzyR9z/ZZJMlMWv37qOOb9pdJlMUEKFQ==", | ||
"dev": true | ||
"integrity": "sha512-quJQXlTSUGL2LH9SUXo8VwsY4soanhgo6LNSm84E1LBcE8s3O0wpdiRzyR9z/ZZJMlMWv37qOOb9pdJlMUEKFQ==" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.json
package-lock.json
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-BRACEEXPANSION-9789073
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)