Cleanup common

[soburi]

No description provided.

[Copilot]

Pull request overview

This PR performs a code formatting cleanup across the Arduino-on-Zephyr core files, standardizing brace style, indentation (switching from 2-space to tab indentation in many files), and related cosmetic changes. It also introduces a correctness fix for printf format specifiers and new support for configurations where digital_pin_gpios is empty.

Changes:

• Format specifier fix in hello_arduino sample (%zd → %zu for size_t)
• Brace style and indentation reformatting across all core .cpp and .h files (opening braces on same line, tabs instead of 2-space indent)
• New #if DT_PROP_LEN > 0 guards and fallback values (port_num = 1, max_ngpios = 0) to support configurations without digital_pin_gpios in the device tree, plus a new helper macro DIGITAL_PIN_GPIOS_FIND_NODE

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
samples/hello_arduino/src/app.cpp	Fixes %zd → %zu for size_t format specifiers
cores/arduino/zephyrSerial.h	Reformats brace style and indentation
cores/arduino/zephyrSerial.cpp	Reformats brace style, indentation, and multi-line macros
cores/arduino/zephyrPrint.h	Reformats brace style and indentation
cores/arduino/zephyrPrint.cpp	Reformats brace style, indentation, and minor whitespace fix
cores/arduino/zephyrCommon.cpp	Reformats indentation; adds #if DT_PROP_LEN > 0 guard with max_ngpios=0/port_num=1 fallback
cores/arduino/main.cpp	Reformats indentation and adds braces to if body
cores/arduino/apiCommon.cpp	Reformats indentation of extern "C" declarations
cores/arduino/Arduino.h	Refactors DIGITAL_PIN_EXISTS into two macros, adds #if DT_PROP_LEN > 0 guard for enum, adds DIGITAL_PIN_GPIOS_FIND_NODE helper macro

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

When digital_pin_gpios has zero entries, the new #else branch sets max_ngpios = 0, which causes struct gpio_port_callback to have a zero-length member array struct arduino_callback handlers[0]. Zero-length arrays are not valid standard C++ (they are a GCC extension). While this works in GCC-based Zephyr builds, it may generate warnings or cause issues with strict-compliance builds. Consider guarding the struct and its related functions with #if DT_PROP_LEN(DT_PATH(zephyr_user), digital_pin_gpios) > 0 as well, or use a minimum size of 1 for max_ngpios in the fallback case.

Suggested change

	const int max_ngpios = 0;
	const int max_ngpios = 1;