Add ES7210 digital microphone support #40
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
drivers/audio/dmic_es7210.c
Outdated
| codec_cfg.dai_route = AUDIO_ROUTE_CAPTURE; | ||
| codec_cfg.dai_type = AUDIO_DAI_TYPE_I2S; | ||
| codec_cfg.dai_cfg.i2s.word_size = stream->pcm_width; | ||
| codec_cfg.dai_cfg.i2s.channels = cfg->channel.req_num_chan; | ||
| codec_cfg.dai_cfg.i2s.format = format; | ||
| codec_cfg.dai_cfg.i2s.options = conf->i2s_options; | ||
| codec_cfg.dai_cfg.i2s.frame_clk_freq = stream->pcm_rate; | ||
| codec_cfg.dai_cfg.i2s.mem_slab = stream->mem_slab; | ||
| codec_cfg.dai_cfg.i2s.block_size = stream->block_size; | ||
| codec_cfg.dai_cfg.i2s.timeout = conf->timeout_ms; | ||
|
|
||
| ret = audio_codec_configure(conf->codec_dev, &codec_cfg); | ||
| if (ret < 0) { | ||
| LOG_ERR("Failed to configure ES7210 codec (%d)", ret); | ||
| return ret; | ||
| } | ||
|
|
||
| audio_codec_stop_output(conf->codec_dev); | ||
|
|
||
| i2s_cfg.word_size = stream->pcm_width; | ||
| i2s_cfg.channels = cfg->channel.req_num_chan; | ||
| i2s_cfg.format = format; | ||
| i2s_cfg.options = conf->i2s_options; | ||
| i2s_cfg.frame_clk_freq = stream->pcm_rate; |
There was a problem hiding this comment.
The DMIC driver derives i2s_options from the devicetree properties and then applies the same flags to both the I²S controller and the ES7210 codec (codec_cfg.dai_cfg.i2s.options = conf->i2s_options; and later i2s_cfg.options = conf->i2s_options). However ES7210_DMIC_OPTIONS() produces settings from the SoC perspective: when the ES7210 is the bit/frame clock master, the macro returns _SLAVE so that the I²S peripheral behaves as a slave, and vice versa. Reusing those flags for the codec therefore programs the codec with the opposite master/slave role advertised in devicetree (e.g. the codec is set as master when the SoC should be master). On real hardware this results in both sides trying to act as the same bus role and the microphone never streams. The codec options need to mirror the devicetree properties while the I²S controller should receive the inverted options.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68e12ab37bf48322a10ef69cfb30384a