Skip to content

Conversation

soburi
Copy link
Owner

@soburi soburi commented Oct 5, 2025

Summary

  • switch the CoreS3 MIPI-DBI node to the shared GPIO35 command/data line without write-only gating
  • declare the ILI9342C panel in 3-wire SPI mode so the display stack expects half-duplex transfers

Testing

  • not run (not requested)

https://chatgpt.com/codex/tasks/task_e_68e20c3c30f08322a324e02063e61aab

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +9 to +11
#include "hal/spi_hal.h"
#include "hal/log.h"
#include "hal/assert.h"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Add missing HAL logging/assert headers

The newly added SPI HAL sources include "hal/log.h" and "hal/assert.h", but those headers do not exist anywhere in the tree or in this commit. Because the files are compiled unconditionally, a normal build will fail with fatal error: hal/log.h: No such file or directory before any functionality can be used. Either provide the corresponding headers or replace these includes with existing Zephyr/IDF logging and assert helpers.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant