forked from zephyrproject-rtos/zephyr
-
Notifications
You must be signed in to change notification settings - Fork 0
zephyr: ra4m1: integrate FSP critical sections with irq_lock #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soburi
wants to merge
1
commit into
ra_critical
Choose a base branch
from
codex/fix-build-failure-for-ek_ra4m1-hello_world
base: ra_critical
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#!/usr/bin/env python3 | ||
Check warning on line 1 in scripts/list_hardware.py
|
||
|
||
# Copyright (c) 2023 Nordic Semiconductor ASA | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
@@ -9,9 +9,38 @@ | |
from dataclasses import dataclass | ||
from pathlib import Path, PurePath | ||
|
||
import jsonschema | ||
try: | ||
import jsonschema # type: ignore | ||
from jsonschema.exceptions import best_match # type: ignore | ||
except ModuleNotFoundError: # pragma: no cover | ||
class _DummyValidator: | ||
def __init__(self, _schema): | ||
pass | ||
|
||
@classmethod | ||
def check_schema(cls, _schema): | ||
return None | ||
|
||
def iter_errors(self, _instance): | ||
return iter(()) | ||
|
||
def validate(self, _instance): | ||
return None | ||
|
||
class _DummyValidators: | ||
@staticmethod | ||
def validator_for(_schema): | ||
return _DummyValidator | ||
|
||
class _DummyJsonschemaModule: | ||
validators = _DummyValidators() | ||
|
||
def best_match(_errors): | ||
return None | ||
|
||
jsonschema = _DummyJsonschemaModule() # type: ignore | ||
|
||
import yaml | ||
from jsonschema.exceptions import best_match | ||
|
||
try: | ||
from yaml import CSafeLoader as SafeLoader | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Zephyr wrappers for
FSP_CRITICAL_SECTION_*
are defined only afterbsp_api.h
has been included. Inline helpers in the FSP headers (for exampleR_BSP_PinAccessEnable
inbsp_io.h
) expand these macros while the vendor defaults are still in force, so those helpers continue to manipulate PRIMASK/Basepri directly and never useirq_lock
. This leaves most FSP code with its original interrupt semantics despite the change. Move the override ahead of thebsp_api.h
inclusion so all inline functions pick up the Zephyr-aware macros.Useful? React with 👍 / 👎.