[READY] - nixos-modules.routers.*: frr updates and ipv6 tests#1104
Merged
[READY] - nixos-modules.routers.*: frr updates and ipv6 tests#1104
Conversation
kylerisse
reviewed
Feb 27, 2026
Comment on lines
157
to
166
| border.wait_until_succeeds("ping -c 5 172.20.3.2", timeout=60) | ||
| border.wait_until_succeeds("ping -c 5 172.20.3.3", timeout=60) | ||
|
|
||
| # conference can reach border-expo link | ||
| conference.succeed("ping -c 5 172.20.2.1") | ||
| conference.succeed("ping -c 5 172.20.2.3") | ||
| conference.wait_until_succeeds("ping -c 5 172.20.2.1", timeout=60) | ||
| conference.wait_until_succeeds("ping -c 5 172.20.2.3", timeout=60) | ||
|
|
||
| # expo can reach conference-border link | ||
| expo.succeed("ping -c 5 172.20.1.1") | ||
| expo.succeed("ping -c 5 172.20.1.2") | ||
| expo.wait_until_succeeds("ping -c 5 172.20.1.1", timeout=60) | ||
| expo.wait_until_succeeds("ping -c 5 172.20.1.2", timeout=60) |
Member
There was a problem hiding this comment.
consistently getting 93s with time nix run .#hydraJobs.scale-nixos-tests.x86_64-linux.routers.driver and a warm cache
________________________________________________________
Executed in 93.14 secs fish external
usr time 14.98 secs 0.00 micros 14.98 secs
sys time 11.87 secs 825.00 micros 11.87 secs
kylerisse
reviewed
Feb 27, 2026
Comment on lines
+133
to
+135
| border.succeed("ping -c 5 2001:470:f026:901::2") | ||
| border.succeed("ping -c 5 172.20.2.3") | ||
| border.succeed("ping -c 5 2001:470:f026:902::3") |
kylerisse
reviewed
Feb 27, 2026
| mkOption | ||
| ; | ||
|
|
||
| genAttrs' = xs: f: listToAttrs (map f xs); |
Well be setting passive-interfaces for ospf6 since it does not have the passive-interface default. Well leave ospf config as-is since its working well with passive-interface default
5f4e277 to
22836aa
Compare
kylerisse
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Including the ospf6 daemon and appropriate v6 links. Additionally support trunk interfaces as args to routers to be able to test between vm and bare metal. Thank you @kylerisse and @djacu for helping with this!
Previous Behavior
New Behavior
Tests