[READY] - nixos-modules.routers.border: heTunnelEnable bool and passive ifaces#1110
Open
sarcasticadmin wants to merge 5 commits intomasterfrom
Open
[READY] - nixos-modules.routers.border: heTunnelEnable bool and passive ifaces#1110sarcasticadmin wants to merge 5 commits intomasterfrom
sarcasticadmin wants to merge 5 commits intomasterfrom
Conversation
b21b7e3 to
7899c53
Compare
sarcasticadmin
commented
Mar 1, 2026
| "bridge104" # expo | ||
| "bridge901" # cf | ||
| ]; | ||
| # service.frr.passive-interface add 103 and 104 later |
Member
Author
There was a problem hiding this comment.
we didnt want 104 here after all since its actually a broadcast interface after the shuffle in #1108
| type filter hook input priority filter; | ||
| policy drop; | ||
| # Show internal traffic (To the router only via the management net) | ||
| iifname { bridge103, backdoor0 } accept; |
Member
Author
There was a problem hiding this comment.
slight deviations from the router-fmt2 config: Including backdoor0 so that interface is still useful
Collaborator
There was a problem hiding this comment.
We might rename the 192.159.10.0/25 interface on FMT2 to backdoor0 to reflect its similar purpose.
| type filter hook forward priority filter; | ||
| policy drop; | ||
| # Show internal traffic | ||
| iifname { bridge103, bridge104, bridge901, bridge903 } oifname { bridge103, bridge104, bridge901, bridge903 } counter accept |
Member
Author
There was a problem hiding this comment.
These bridges were paired down since we dont have as many as we do on router-fmt2 (since its more like a border + expo config)
Contributor
|
Seems sound to me. Would approve if I could... |
owendelong
approved these changes
Mar 1, 2026
Collaborator
owendelong
left a comment
There was a problem hiding this comment.
Looks great... Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixes: #1094
Mimic the existing firewall rules we have in dev environment in fmt2:
scale-network/nix/nixos-configurations/router-scale-br-fmt2/default.nix
Lines 50 to 106 in f6e1e95
Additionally we include the he tunnel which is also enabled in the offseason on the same router:
scale-network/nix/nixos-configurations/router-scale-br-fmt2/default.nix
Lines 115 to 124 in f6e1e95
Previous Behavior
New Behavior
Tests
heTunnelEnabletoggle:borderexpoandconfbare metal and frr and pings looked goodborderin vtysh:show ip ipv6 opsf6 interaceslooking forNo Hellos (Passive interface)on WAN and bridge103