Update snmp.yml with SNMP Retries and Timeout Values#939
Open
Update snmp.yml with SNMP Retries and Timeout Values#939
Conversation
owendelong
approved these changes
Mar 7, 2025
Contributor
|
This seems quite reasonable to me, but the live code was cherry picked by @sarcasticadmin from #933 |
owendelong
approved these changes
Jan 15, 2026
Collaborator
owendelong
left a comment
owendelong
left a comment
There was a problem hiding this comment.
Seems like formatting changes only.
Collaborator
|
I leave it to @MrHamel or @sarcasticadmin to resolve the merge conflicts. |
kylerisse
requested changes
Jan 15, 2026
Member
kylerisse
left a comment
kylerisse
left a comment
There was a problem hiding this comment.
this is stale and might not align with new monitoring setup, don't merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Add retries and timeouts to Prometheus SNMP exporter.
Previous Behavior
No retries or timeouts were defined, causing data to not be collected.
New Behavior
Add retries and timeouts, in the hopes that data will be collected, regardless of how long it takes.