Skip to content

Add listing of all open pull requests sorted by open time#253

Open
jens-mueller-sociomantic wants to merge 5 commits intosociomantic-tsunami:v0.x.xfrom
jens-mueller-sociomantic:time-open
Open

Add listing of all open pull requests sorted by open time#253
jens-mueller-sociomantic wants to merge 5 commits intosociomantic-tsunami:v0.x.xfrom
jens-mueller-sociomantic:time-open

Conversation

@jens-mueller-sociomantic

This implements the command time_open. It will output the list of open
pull requests for a repository sorted by open time. This is implemented
by performing a GraphQL query against the GitHub API service and sorting
the output.

This adds the skeleton to build the empty application called time_open.
The purpose of the application is to list latest open pull requests for
a repository.
@jens-mueller-sociomantic
Copy link
Author

@shiv-tiwari-dunnhumby This is the tool we talked about. Please have a look.


*******************************************************************************/

version(unittest) {} else

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a bad idea. When make unittest is done, there will be 2 main and the linker will complain.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused I just copied from src/autopr/main.d. Why will there be two mains? Doesn't this only add the main, when you are not in a unittest.

Copy link
Author

@jens-mueller-sociomantic jens-mueller-sociomantic Sep 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed code in a fixup commit to add an empty main for unittests. I'm still puzzled because the other tools don't need it.

@jens-mueller-sociomantic
Copy link
Author

@leandro-lucarella-sociomantic Any idea why the build is failing? I didn't change dub dependencies.

This implements the command `time_open`. It will output the list of open
pull requests for a repository sorted by open time. This is implemented
by performing a GraphQL query against the GitHub API service and sorting
the output.
@jens-mueller-sociomantic
Copy link
Author

The latest dyaml 0.8.0 seems to not work any more with dmd 2.080.*. Either we drop support for this compiler version or we stay on an older version of dyaml.

@leandro-lucarella-sociomantic
Copy link
Contributor

No idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants