Skip to content

Commit e08293b

Browse files
refactor(eio): use URL constructor instead of url.parse()
1 parent b837949 commit e08293b

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

packages/engine.io/lib/server.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import * as qs from "querystring";
2-
import { parse } from "url";
31
import * as base64id from "base64id";
42
import transports from "./transports";
53
import { EventEmitter } from "events";
@@ -736,9 +734,8 @@ export class Server extends BaseServer {
736734
private prepare(req: EngineRequest) {
737735
// try to leverage pre-existing `req._query` (e.g: from connect)
738736
if (!req._query) {
739-
req._query = (
740-
~req.url.indexOf("?") ? qs.parse(parse(req.url).query) : {}
741-
) as Record<string, string>;
737+
const url = new URL(req.url, "https://socket.io");
738+
req._query = Object.fromEntries(url.searchParams.entries());
742739
}
743740
}
744741

0 commit comments

Comments
 (0)