Skip to content

Properly strip whitespace from the right side of header values #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Properly strip whitespace from the right side of header values #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/protocol/http1/connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ module HTTP1
FIELD_NAME = TOKEN
OWS = /[ \t]*/
# A field value is any string of characters that does not contain a null character, CR, or LF. After reflecting on the RFCs and surveying real implementations, I came to the conclusion that the RFCs are too restrictive. Most servers only check for the presence of null bytes, and obviously CR/LF characters have semantic meaning in the parser. So, I decided to follow this defacto standard, even if I'm not entirely happy with it.
FIELD_VALUE = /[^\0\r\n]+/.freeze
HEADER = /\A(#{FIELD_NAME}):#{OWS}(?:(#{FIELD_VALUE})#{OWS})?\z/.freeze
FIELD_VALUE = /[^\0\r\n]*?/.freeze
HEADER = /\A(#{FIELD_NAME}):#{OWS}(#{FIELD_VALUE})#{OWS}\z/.freeze

VALID_FIELD_NAME = /\A#{FIELD_NAME}\z/.freeze
VALID_FIELD_VALUE = /\A#{FIELD_VALUE}?\z/.freeze
VALID_FIELD_VALUE = /\A#{FIELD_VALUE}\z/.freeze

DEFAULT_MAXIMUM_LINE_LENGTH = 8192

Expand Down
13 changes: 13 additions & 0 deletions test/protocol/http1/connection/headers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,19 @@ def validate_headers!(expected_headers = self.headers)
end
end

with "a header that contains trailing whitespace" do
let(:headers) {[
"has-trailing-whitespace: here it is \t"
]}

it "can parse the header" do
authority, method, target, version, headers, body = server.read_request
expect(headers).to have_keys(
"has-trailing-whitespace" => be == ["here it is"]
)
end
end

with "a header that contains obsolete folding whitespace" do
let(:headers) {[
"user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko)\n\tChrome/55.0.2883.95 Safari/537.36"
Expand Down
Loading