Cowboy 0.10.0 support and small fix #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error in JsessionidCookie.test_xhr sockjs-protocol test Name of cookie for cowboy_req must be upper-cased
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits for cowboy 0.10.0 support.
And fix for JsessionidCookie.test_xhr sockjs-protocol test. (passed now)
After changes sockjs-protocol tests shows (failures=1, errors=5) all errors and failures in WebsocketHixie76 protocol test:
All this errors happens because after returning {upgrade, protocol, cowboy_websocket} in cowboy_handler, Cowboy server answers with error 400. I have no idea why it happens.
But on client side everything works. All sockjs-client tests in Chrome, Safari and Firefox 100% passed.