[Tutorial] How to develop single page application with Angular#281
Open
rishibaghel25 wants to merge 18 commits intosodafoundation:masterfrom
Open
[Tutorial] How to develop single page application with Angular#281rishibaghel25 wants to merge 18 commits intosodafoundation:masterfrom
rishibaghel25 wants to merge 18 commits intosodafoundation:masterfrom
Conversation
Update readme.md
Update readme.md
Update readme.md
Update readme.md
Update readme.md
anvithks
requested changes
Mar 23, 2023
Member
There was a problem hiding this comment.
Thanks for the PR @rishibaghel25 @2108vijay @reevdonatusben789 @priyakumari16
A few suggestions and changes requested.
- You can remove the code for the sample project from here and host it in a repo of its own and provide the link. We just want the readme document on how to setup angular routing.
The documentation that you have to write is not for building a simple Angular app. It is for Angular routing. I do not see any information regarding Angular routing and how to use it. Consider adding that to the documentation.- The Readme at the root folder
learning/dashboardhas been deleted. Please add it back.
Edit: My mistake. I mixed up the two PRs for angular app and Angular routing.
learning/dashboard/How to develop single page application with Angular/readme.md
Outdated
Show resolved
Hide resolved
learning/dashboard/How to develop single page application with Angular/Hello-World/.gitignore
Outdated
Show resolved
Hide resolved
...ning/dashboard/How to develop single page application with Angular/Hello-World/.editorconfig
Outdated
Show resolved
Hide resolved
...ashboard/How to develop single page application with Angular/Hello-World/.vscode/launch.json
Outdated
Show resolved
Hide resolved
Author
|
changes done |
anvithks
approved these changes
Mar 27, 2023
Member
anvithks
left a comment
There was a problem hiding this comment.
LGTM!
Thank you @rishibaghel25 @priyakumari16 @Rishikesh-50 @reevdonatusben789 @2108vijay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Test Report Added?:
Test Report:
Special notes for your reviewer: