[Vmware/NGC] Junit integration test for device repository service#339
Open
NajmudheenCT wants to merge 7 commits intosodafoundation:developmentfrom
Open
[Vmware/NGC] Junit integration test for device repository service#339NajmudheenCT wants to merge 7 commits intosodafoundation:developmentfrom
NajmudheenCT wants to merge 7 commits intosodafoundation:developmentfrom
Conversation
skdwriting
reviewed
Feb 7, 2020
Collaborator
skdwriting
left a comment
skdwriting
left a comment
There was a problem hiding this comment.
Also there are some merge conflicts. Kindly handle it.
| <scope>compile</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>junit</groupId> |
Member
Author
There was a problem hiding this comment.
Yes, it was merge from previos PR. Removed now.
| <version>4.12</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
Collaborator
There was a problem hiding this comment.
can you please check all the dependencies with right versions are added only once and correct. Thanks.
Member
Author
There was a problem hiding this comment.
Yes, Maven will download all depended jars. The versions now we specified are compatable. I hae tested this by building on different machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As of now there is no test functions in Plugin. This is the first set of Junits added for NGC-Plugin project. DeviceServiceImpl class is picked first and added on IT for this.
Which issue this PR fixes
NA
Special notes for your reviewer:
This is an IT which needs a config file to be updated in test/resources folder.
Testing note:
Test has been run from both eclipse and terminal. Coverage report is captured from eclipse.