fix(crush): preserve values when object keys contain dots#471
Open
kaigritun wants to merge 1 commit intosodiray:masterfrom
Open
fix(crush): preserve values when object keys contain dots#471kaigritun wants to merge 1 commit intosodiray:masterfrom
kaigritun wants to merge 1 commit intosodiray:masterfrom
Conversation
When an object contains keys with dots (e.g., 'bar.baz'), the crush function would return undefined for those values. This happened because crush used keys() to generate dot-notation paths, then get() to retrieve values. When a key literally contains a dot, get() would split it and look for nested properties that don't exist. Fixed by refactoring crush to iterate recursively through the object and directly assign values to the result, rather than using keys() + get(). Fixes sodiray#468
|
Someone is attempting to deploy a commit to the rayunishinedev's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
hahaha ai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an object contains keys with dots (e.g.,
'bar.baz'), thecrushfunction returnsundefinedfor those values:Root Cause
The
crushfunction usedkeys()to generate dot-notation paths, thenget()to retrieve values. When a key literally contains a dot,get()splits the path by dots and looks for nested properties that don't exist.Solution
Refactored
crushto iterate recursively through the object and directly assign values to the result, rather than usingkeys()+get(). This preserves the actual value regardless of what characters the key contains.Changes
crushinsrc/object.tsto use a recursive approachTesting
All existing tests pass, plus the new edge case test.
Fixes #468