Fix saving of settings.ini#260
Merged
hugtalbot merged 1 commit intosofa-framework:masterfrom Jan 15, 2026
Merged
Conversation
bakpaul
approved these changes
Jan 15, 2026
bakpaul
pushed a commit
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first time
SofaImGuiruns, the folderimguidoes not exist in config directory. That is why we have the functionensureFolderExists. However, the function does not take the full path. Therefore, the folder still does not exist. Because of that, it is not possible to save the ini file in this folder.Later in the code, the folder is created, and the ini file can be saved.
This PR fixes the call to
ensureFolderExistsso that theinifile is saved the first time.