Skip to content

[bindings] FIX FileRepository binding (doLowerCaseOnWin32 removal) #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredroy merged 1 commit into from
Jun 28, 2021
Merged

[bindings] FIX FileRepository binding (doLowerCaseOnWin32 removal) #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/Sofa/src/SofaPython3/Sofa/Helper/System/Binding_FileRepository.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ void moduleAddFileRepository(py::module &m) {
file_repository.def_static(
"relativeToPath",
&sofa::helper::system::FileRepository::relativeToPath,
py::arg("path").none(false), py::arg("refPath").none(false), py::arg("doLowerCaseOnWin32") = true,
py::arg("path").none(false), py::arg("refPath").none(false),
doc::FileRepository::relativeToPath
);

Expand Down
3 changes: 0 additions & 3 deletions bindings/Sofa/src/SofaPython3/Sofa/Helper/System/Binding_FileRepository_doc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,6 @@ static auto relativeToPath =
R"(
Returns a string such as refPath + string = path if path contains refPath.
Otherwise returns path.
On WIN32 the implementation was also returning the path in lower case. This behavior is now
deprecated and should be remove the 2018-05-01. Until this date new implementation can be
used by setting doLowerCaseOnWin32=false;
)";

static auto getPathsJoined =
Expand Down
5 changes: 1 addition & 4 deletions docs/sphinx-stubs/Sofa/Helper/System/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,10 @@ class FileRepository():
Print the list of path to std::cout.
"""
@staticmethod
def relativeToPath(path: str, refPath: str, doLowerCaseOnWin32: bool = True) -> str:
def relativeToPath(path: str, refPath: str) -> str:
"""
Returns a string such as refPath + string = path if path contains refPath.
Otherwise returns path.
On WIN32 the implementation was also returning the path in lower case. This behavior is now
deprecated and should be remove the 2018-05-01. Until this date new implementation can be
used by setting doLowerCaseOnWin32=false;
"""
def removePath(self, path: str) -> None:
"""
Expand Down