Skip to content

Conversation

@lkarstensen
Copy link

No description provided.

@fredroy
Copy link
Contributor

fredroy commented Aug 25, 2021

Hello, sorry I did not see this PR while doing #166 😮
However, your fix does not work on my side. Moreover you seem to want to link on the libs of the build directory and not the libs from the install directory. Finally, you did not set for WIN32 as well.

IMO, it is better to link on the libs from the install. Your opinion @jnbrunet ?

@jnbrunet
Copy link
Contributor

Indeed @fredroy , I agree we should go forward with #166. Thanks a lot @lkarstensen for raising this issue, and very sorry for the delay, summer time is usually a bit slow !

@jnbrunet jnbrunet closed this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants