[all] FIX the packaging system. #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial problem is that the SP3_add_python_package (and few others) was using configure_file() to install python package into the build dir (as well as install dir). The problem is that configure_file, because of the variable expansion, create a link between the file and CMake...so each time the file is touched, cmake is re-executed. To me it make no sense to use configure for every .py unless you really want variable expansion (and thus have an explicit filename.py.in) for that. So I refactor the whole thing to: - stop using configure_file - make a link between the python files from the source dir to the build dir, so (so we can now edit python bug without noticing too late that we touched the files in build directory). - make an install process that copy the files (and not the links) - put all the test-files at the same location in various tests
Contributor
|
Hey @damienmarchal Just a small note: your PR isn't forgotten. We are working on putting back the CI on its foot. Then I'll rebase your branch and merge it if the tests passes. |
Contributor
|
Hey @damienmarchal , I've updated your branch with master, however I do not have the permission to push to it. Do you want me to create a new PR with the updated branch? |
Contributor
|
I see this is not active anymore since September, should we close it @damienmarchal ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial problem is that the SP3_add_python_package (and few others) was using
configure_file() to install python package into the build dir (as well as install dir).
The problem is that configure_file, because of the variable expansion, create a link
between the file and CMake...so each time the file is touched, cmake is re-executed.
To me it make no sense to use configure for every .py unless you really want variable expansion (and thus have an
explicit filename.py.in) for that.
So I refactor the whole thing to:
(so we can now edit python bug without noticing too late that we touched the files in build directory).