Skip to content

[Simulation.Core] Apply new factory registration mechanism #5098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugtalbot merged 2 commits into from
Dec 10, 2024
Merged

[Simulation.Core] Apply new factory registration mechanism #5098

hugtalbot merged 2 commits into from
Dec 10, 2024

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Nov 6, 2024

See

some works still need to be done in the future to avoid calling a singleton for the ObjectFactory

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress pr: new feature Implement a new feature pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Nov 6, 2024
@fredroy
Copy link
Contributor Author

fredroy commented Nov 6, 2024

[ci-build][with-all-tests]

@alxbilger alxbilger added this to the v24.12 milestone Dec 4, 2024
@fredroy fredroy mentioned this pull request Dec 10, 2024
Merged
hugtalbot
hugtalbot requested changes Dec 10, 2024
View reviewed changes
@hugtalbot hugtalbot merged commit e694dc8 into sofa-framework:master Dec 10, 2024
7 of 11 checks passed
@hugtalbot hugtalbot deleted the register_core branch December 10, 2024 10:08
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

@bakpaul bakpaul bakpaul approved these changes

Assignees

No one assigned

Labels

pr: new feature Implement a new feature pr: status ready Approved a pull-request, ready to be squashed

Projects

Refactor object registration
Status: Done

Milestone

v24.12

Development

Successfully merging this pull request may close these issues.

4 participants

@fredroy @hugtalbot @bakpaul @alxbilger