Skip to content

Conversation

@hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Mar 5, 2025

Mostly, fixes related to vec_id recovered commits from #5245 :


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Mar 5, 2025
@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests]

@fredroy fredroy force-pushed the 202503_fix_before_lifecycle branch from f38e729 to 04d683e Compare March 6, 2025 02:05
Copy link
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to wait for one more week I think. It was already covered in the aforementioned PR

@bakpaul bakpaul merged commit f40e8ca into sofa-framework:master Mar 6, 2025
10 of 11 checks passed
@bakpaul bakpaul added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 6, 2025
@hugtalbot hugtalbot added this to the v25.06 milestone Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants