Skip to content

[all] Lifecycle : remove SOFA_HEADER_DISABLED #5327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fredroy merged 13 commits into from
Mar 17, 2025
Merged

[all] Lifecycle : remove SOFA_HEADER_DISABLED #5327

fredroy merged 13 commits into from
Mar 17, 2025

Conversation

@hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Mar 14, 2025

Based on #5309

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Mar 14, 2025
@hugtalbot
Copy link
Contributor Author

hugtalbot commented Mar 14, 2025

[ci-build][with-all-tests]

@bakpaul bakpaul added pr: fast merge Minor change that can be merged without waiting for the 7 review days and removed pr: clean Cleaning the code labels Mar 14, 2025
@hugtalbot hugtalbot added the pr: clean Cleaning the code label Mar 16, 2025
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 17, 2025
@fredroy fredroy merged commit 65585af into sofa-framework:master Mar 17, 2025
15 checks passed
@hugtalbot hugtalbot added this to the v25.06 milestone Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bakpaul bakpaul bakpaul approved these changes

Assignees

No one assigned

Labels

pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Milestone

v25.06

Development

Successfully merging this pull request may close these issues.

3 participants

@hugtalbot @bakpaul @fredroy