[Collision] Set Data and SingleLinks to public in PointCollisionModel#5969
Open
th-skam wants to merge 1 commit intosofa-framework:masterfrom
Open
[Collision] Set Data and SingleLinks to public in PointCollisionModel#5969th-skam wants to merge 1 commit intosofa-framework:masterfrom
th-skam wants to merge 1 commit intosofa-framework:masterfrom
Conversation
th-skam
added
pr: status to review
alxbilger
reviewed
Feb 25, 2026
Contributor
alxbilger
left a comment
alxbilger
left a comment
There was a problem hiding this comment.
Yes, Links and Data should be public. In any case, they can be accessed publicly (for example using findData, or in Python), so it makes sense that they are also public in C++.
As a side note, mstate should be a link too.
th-skam
added
pr: status wip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit of an inconsistency since the topology link (and Data) are mostly public in other model classes. Same with Sphere coli model.
Was this by design? Let's keep one consistent style for all models.
What do you think? should they be public or private?