Route param values cleanup #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #130 +/- ##
============================================
- Coverage 97.33% 97.31% -0.02%
+ Complexity 509 507 -2
============================================
Files 69 69
Lines 1426 1417 -9
============================================
- Hits 1388 1379 -9
Misses 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Brajk19
force-pushed
the
route-param-value-cleanup
branch
from
de0342b to
8a497ca
Compare
HypeMC
reviewed
Dec 17, 2025
src/Cache/PropertyResolver/InverseValuesBuilder/DynamicInverseValuesBuilder.php
Outdated
Show resolved
Hide resolved
HypeMC
reviewed
Dec 17, 2025
Brajk19
force-pushed
the
route-param-value-cleanup
branch
from
ab4b9b0 to
ac6333e
Compare
HypeMC
force-pushed
the
route-param-value-cleanup
branch
from
df349de to
d578ed2
Compare
HypeMC
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompoundValuesno longer extendAbstractValues- it direclty implementsValueInterfacebecause of custom implementiation oftoArraygetValuesshould not be used outside ofAbstractValuesandtoArray. inverse builders know exactly which type of values they are handling, so they can directly access properties (they are now public)