Skip to content

Simplify command arg definition #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HypeMC merged 1 commit into from
Dec 18, 2025
Merged

Simplify command arg definition #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,6 @@ parameters:
count: 1
path: src/Cache/RouteMetadata/YamlMetadataProvider.php

-
message: '#^Strict comparison using \=\=\= between 8 and 6 will always evaluate to false\.$#'
identifier: identical.alwaysFalse
count: 1
path: src/Command/DebugCommand.php

-
message: '#^Parameter \#2 \$configurator of method Symfony\\Component\\DependencyInjection\\ContainerBuilder\:\:registerAttributeForAutoconfiguration\(\) expects callable\(Symfony\\Component\\DependencyInjection\\ChildDefinition, Sofascore\\PurgatoryBundle\\Attribute\\AsExpressionLanguageFunction, Reflector\)\: void, Closure\(Symfony\\Component\\DependencyInjection\\ChildDefinition, Sofascore\\PurgatoryBundle\\Attribute\\AsExpressionLanguageFunction, ReflectionClass\|ReflectionMethod\)\: void given\.$#'
identifier: argument.type
Expand Down
16 changes: 1 addition & 15 deletions src/Command/DebugCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;
use Symfony\Component\HttpKernel\Kernel;

#[AsCommand(
name: 'purgatory:debug',
Expand All @@ -36,20 +35,7 @@ public function __construct(

protected function configure(): void
{
$params = [
'name' => 'target',
'mode' => InputArgument::OPTIONAL,
'description' => 'The entity name or a substring of its name',
'default' => null,
'suggestedValues' => array_keys($this->getEntityCollection()),
];

if (Kernel::MAJOR_VERSION === 6) {
// cannot use named arguments with SF6
$params = array_values($params);
}

$this->addArgument(...$params);
$this->addArgument('target', InputArgument::OPTIONAL, 'The entity name or a substring of its name', null, array_keys($this->getEntityCollection()));
$this->addOption('subscription', null, InputOption::VALUE_REQUIRED, 'The entity FQCN, optionally followed by a property path separated by "::"');
$this->addOption('with-properties', null, InputOption::VALUE_NONE, 'Display all property subscriptions for an entity');
$this->addOption('route', null, InputOption::VALUE_REQUIRED, 'Display subscriptions for specific route');
Expand Down
Loading