Skip to content

Revert "Change OSSRH to Central Portal"#1383

Merged
CrazyHZM merged 1 commit intomasterfrom
revert-1382-4.x_feat/nexus-staging-maven-plugin
Jul 2, 2025
Merged

Revert "Change OSSRH to Central Portal"#1383
CrazyHZM merged 1 commit intomasterfrom
revert-1382-4.x_feat/nexus-staging-maven-plugin

Conversation

@CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Jul 2, 2025

Reverts #1382

Summary by CodeRabbit

  • Chores
    • Updated Maven configuration to use the latest Sonatype OSS repositories and the recommended staging plugin for releases.
    • Improved repository and plugin repository definitions for clearer separation of release and snapshot deployments.
    • No changes to application features or public APIs; these updates only affect the build and release process.

@coderabbitai
Copy link

coderabbitai bot commented Jul 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The Maven build configuration was updated to replace the deprecated central-publishing-maven-plugin with the nexus-staging-maven-plugin, update repository URLs to Sonatype OSS, and adjust related plugin and repository configuration parameters in both the main and test POM files. No Java code or public entity changes were made.

Changes

File(s) Change Summary
pom.xml Replaced central-publishing-maven-plugin with nexus-staging-maven-plugin; updated plugin config, repository URLs, and removed deprecated properties. Added/updated <distributionManagement>, <repositories>, and <pluginRepositories> for Sonatype OSS.
sofa-boot-tests/pom.xml Switched plugin from central-publishing-maven-plugin to nexus-staging-maven-plugin; updated plugin version property and config parameter for skipping deployment.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Maven
    participant Sonatype OSS

    Developer->>Maven: mvn deploy (with release profile)
    Maven->>nexus-staging-maven-plugin: Prepare deployment
    nexus-staging-maven-plugin->>Sonatype OSS: Upload artifacts to staging repository
    Sonatype OSS-->>nexus-staging-maven-plugin: Acknowledge receipt
    nexus-staging-maven-plugin-->>Maven: Deployment complete (auto-release disabled)
Loading

Possibly related PRs

  • Change OSSRH to Central Portal #1382: This PR previously switched from nexus-staging-maven-plugin to central-publishing-maven-plugin, and the current changes directly reverse that, updating plugin configuration and repository URLs accordingly.
  • Upgrade staging plugin version to 1.7.0 #1381: Upgraded the version of the nexus-staging-maven-plugin used in the POM, related to plugin configuration and deployment process.

Suggested labels

size/XS

Poem

A hop and a skip, the plugins have changed,
From central to nexus, the configs rearranged!
Sonatype’s OSS now hosts our deploy,
With URLs and IDs that bring us much joy.
The tests and the build, in harmony sing—
A Maveny update, a springtime fling!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88bf7da and 81ad387.

📒 Files selected for processing (2)
  • pom.xml (2 hunks)
  • sofa-boot-tests/pom.xml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@CrazyHZM CrazyHZM merged commit 534cffd into master Jul 2, 2025
6 of 7 checks passed
@CrazyHZM CrazyHZM deleted the revert-1382-4.x_feat/nexus-staging-maven-plugin branch July 2, 2025 06:47
@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (88bf7da) to head (81ad387).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1383      +/-   ##
============================================
+ Coverage     82.91%   82.94%   +0.03%     
- Complexity     2972     2974       +2     
============================================
  Files           340      340              
  Lines          9833     9833              
  Branches       1178     1178              
============================================
+ Hits           8153     8156       +3     
  Misses         1164     1164              
+ Partials        516      513       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant