Skip to content

Conversation

@EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Oct 17, 2025

update rpc version to 5.14.0

Summary by CodeRabbit

  • Chores
    • Version upgraded to 5.14.0 (from pre-release version).
    • Build metadata and configuration updated.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 17, 2025

Walkthrough

This PR updates the project version from 5.14.0-SNAPSHOT to 5.14.0 across Maven configuration files and the Version constant, reflecting a version release with an updated build timestamp (20251017144925).

Changes

Cohort / File(s) Summary
POM Configuration Files
all/pom.xml, bom/pom.xml, pom.xml
Updated version and revision properties from 5.14.0-SNAPSHOT to 5.14.0 for release version.
Java Version Constant
core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java
Updated BUILD_VERSION constant from 5.14.0_20241101180137 to 5.14.0_20251017144925.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • Lo1nt
  • chuailiwu
  • wangchengming666

Poem

🐰 A hop, a skip, the version's ripe,
From SNAPSHOT dreams to release type,
Five-fourteen shines in golden light,
The timestamp hops—another night! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "update rpc version to 5.14.0" directly and accurately describes the primary change in the changeset. All modifications across the four files (all/pom.xml, bom/pom.xml, core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java, and pom.xml) are focused on updating the version from 5.14.0-SNAPSHOT to 5.14.0 and the build timestamp. The title is concise, specific, and clearly conveys the main intent of the pull request without vague terms or unnecessary details. A teammate reviewing the commit history would immediately understand this is a version release update.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update_rpc_051400_release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java (1)

40-40: Build version updated correctly.

The timestamp update (20251017144925) aligns with the release date and version bump. The FIXME comment on line 23 suggests this is a manual process—consider automating the build timestamp injection via Maven properties or build plugins to reduce the risk of human error in future releases.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0150abc and 9500ca3.

📒 Files selected for processing (4)
  • all/pom.xml (1 hunks)
  • bom/pom.xml (1 hunks)
  • core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java (1 hunks)
  • pom.xml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: sca
🔇 Additional comments (3)
bom/pom.xml (1)

13-13: LGTM!

The BOM revision update is consistent with the root POM change, ensuring proper dependency management for the release.

all/pom.xml (1)

9-9: LGTM!

The version update is consistent with the release. All version changes across the project align with the 5.14.0 release.

pom.xml (1)

80-80: Verify version management strategy for all/pom.xml.

The verification found an inconsistency: all/pom.xml lacks a parent declaration and uses hardcoded <version>5.14.0</version> instead of ${revision}. While the main pom.xml and bom/pom.xml properly use ${revision} for centralized versioning, this orphaned module won't automatically sync if the revision property is updated in the future. Confirm whether all/pom.xml is intentionally independently versioned or should be refactored to inherit versioning from the parent.

@EvenLjj EvenLjj merged commit ca89834 into master Oct 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants