-
Notifications
You must be signed in to change notification settings - Fork 1.2k
update rpc version to 5.14.0 #1514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR updates the project version from 5.14.0-SNAPSHOT to 5.14.0 across Maven configuration files and the Version constant, reflecting a version release with an updated build timestamp (20251017144925). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java (1)
40-40: Build version updated correctly.The timestamp update (20251017144925) aligns with the release date and version bump. The FIXME comment on line 23 suggests this is a manual process—consider automating the build timestamp injection via Maven properties or build plugins to reduce the risk of human error in future releases.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
all/pom.xml(1 hunks)bom/pom.xml(1 hunks)core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java(1 hunks)pom.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: sca
🔇 Additional comments (3)
bom/pom.xml (1)
13-13: LGTM!The BOM revision update is consistent with the root POM change, ensuring proper dependency management for the release.
all/pom.xml (1)
9-9: LGTM!The version update is consistent with the release. All version changes across the project align with the 5.14.0 release.
pom.xml (1)
80-80: Verify version management strategy for all/pom.xml.The verification found an inconsistency:
all/pom.xmllacks a parent declaration and uses hardcoded<version>5.14.0</version>instead of${revision}. While the main pom.xml and bom/pom.xml properly use${revision}for centralized versioning, this orphaned module won't automatically sync if the revision property is updated in the future. Confirm whether all/pom.xml is intentionally independently versioned or should be refactored to inherit versioning from the parent.
update rpc version to 5.14.0
Summary by CodeRabbit