Skip to content

Conversation

@EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Oct 18, 2025

update nexusUrl

Summary by CodeRabbit

  • Chores
    • Updated internal Maven build configuration for artifact staging deployment.

Note: These changes do not affect user-facing functionality or features.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 18, 2025

Walkthrough

This PR updates Maven POM files to redirect the nexus-staging-maven-plugin's nexusUrl configuration from the central Sonatype repository to the OSSRH staging API endpoint. The changes affect Maven deployment configuration without modifying plugin behavior or public APIs.

Changes

Cohort / File(s) Change Summary
Nexus Staging Plugin URL Configuration
all/pom.xml, compiler/pom.xml
Updated nexus-staging-maven-plugin's nexusUrl parameter from central Sonatype endpoint to OSSRH staging API URL, redirecting where staging deployments are sent

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Rationale: Configuration-only changes with consistent, repetitive pattern across files. No logic modifications, behavioral changes, or public API impacts. Straightforward Maven endpoint redirection.

Possibly related PRs

  • modify maven repo #1515: Modifies Maven repository endpoints in POM files to switch deployment/snapshot URLs to OSSRH staging/central endpoints—directly analogous configuration changes.

Suggested reviewers

  • chuailiwu
  • sunhailin-Leo

Poem

🐰 Hop along, the staging path is clear,
Maven plugins now know where to steer,
From central URLs to OSSRH so bright,
Deployments redirect—everything's right! 📦✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "update nexusUrl" is directly related to the main change in the changeset. Both all/pom.xml and compiler/pom.xml update the nexusUrl parameter in the nexus-staging-maven-plugin configuration from the central Sonatype endpoint to the staging API endpoint. The title accurately identifies what was changed and is specific enough to convey the primary modification, rather than being vague or misleading. While the title could provide more context about the purpose of the change (switching to staging API), it is sufficiently clear for a teammate scanning the git history to understand that Nexus URL configuration was updated.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3eed24c and ace1981.

📒 Files selected for processing (2)
  • all/pom.xml (1 hunks)
  • compiler/pom.xml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: sca
🔇 Additional comments (2)
compiler/pom.xml (1)

195-195: Verify nexusUrl format for OSSRH Staging API compatibility.

Official Sonatype documentation recommends configuring nexusUrl as https://ossrh-staging-api.central.sonatype.com/service/local/, which includes the /service/local/ suffix. The current value in this PR omits that suffix and only provides the base URL.

The distributionManagement repository URL at Line 220 already uses the full path. Consider verifying that nexus-staging-maven-plugin 1.6.7 correctly handles the base URL format, or align it with the official documentation by adding the /service/local/ suffix.

all/pom.xml (1)

648-648: Confirm consistency: nexusUrl format matches across modules.

Both compiler/pom.xml and all/pom.xml have been updated identically to use the base URL format without the /service/local/ suffix. While this maintains consistency across the codebase, official Sonatype OSSRH Staging API documentation shows the full path with /service/local/ included.

Verify that this base URL format is compatible with nexus-staging-maven-plugin 1.6.7, or update both files to match the official recommendation.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvenLjj EvenLjj merged commit 58db5b6 into sofastack:master Oct 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants