Skip to content

#41 Escape output#42

Open
cmdmcs wants to merge 1 commit intomasterfrom
fix/41-escape-output
Open

#41 Escape output#42
cmdmcs wants to merge 1 commit intomasterfrom
fix/41-escape-output

Conversation

@cmdmcs
Copy link
Contributor

@cmdmcs cmdmcs commented Feb 5, 2022

No description provided.

@cmdmcs cmdmcs requested a review from Programmer095 February 5, 2022 14:29
@Programmer095
Copy link
Contributor

Programmer095 commented Feb 8, 2022

@cmdmcs It looks like the echo for helper_metabox_top() L419 should be escaped as it includes the slug and name in what's being echoed. We should probably escape helper_metabox_bottom L443 also for consistency.

The localization L868 should be removed also since they don't support variables.

@Programmer095
Copy link
Contributor

@cmdmcs just following up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants