Skip to content

Conversation

@ltratt
Copy link
Member

@ltratt ltratt commented Feb 4, 2025

No description provided.

@ratmice
Copy link
Collaborator

ratmice commented Feb 4, 2025

LGTM

@ratmice ratmice added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@ratmice
Copy link
Collaborator

ratmice commented Feb 4, 2025

I assume this is just the ci having updated one of rustdoc/clippy since the commits landed, updating to see if I can reproduce locally.

@ratmice ratmice mentioned this pull request Feb 4, 2025
@ltratt
Copy link
Member Author

ltratt commented Feb 4, 2025

Weirdly that error only seems to crop up with rustdoc. c2f6221 should fix it.

@ratmice ratmice added this pull request to the merge queue Feb 4, 2025
Merged via the queue into softdevteam:master with commit f5f36cf Feb 4, 2025
2 checks passed
@ratmice
Copy link
Collaborator

ratmice commented Feb 4, 2025

Curious I see now I needed to download the build logs manually, as it doesn't scroll up/show the entire log.

Anyhow trying that failing command RUSTDOCFLAGS=-Dwarnings cargo doc --no-deps locally, still can't reproduce though that seems to obviously be the solution.

@ltratt
Copy link
Member Author

ltratt commented Feb 4, 2025

Buildbot doesn't make the logs as obvious as one might hope, but there is a button to display all of them in the browser (including while they're ongoing). CI is hard! But thanks for looking at this -- I really appreciate it!

@ltratt ltratt deleted the grmtools_0_13_9 branch May 25, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants