Add regex error source to RegexError
#502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking as a draft, because this is perhaps questionable.
Here is the example source producing the error.
There are two questionable things here, the first being the
Eqimplementation relying onregex::Error'sto_string()impl,because
regex::Erroris onlyPartialEq.The second being when we run the example through nimbleparse we see the
regex::Errorincludes lrlex's wrapping of the regular expression e.g.\A(:?unfortunately, regex doesn't really give us any kind of Span we otherwise might be able to use to translate this back to the lex source locations.Previously this just produced "Invalid regular expression", with this change it now produces a reason.
So, I'm a bit torn on this because I do feel like the extra information is helpful.