Skip to content

Conversation

@ratmice
Copy link
Collaborator

@ratmice ratmice commented May 22, 2025

I believe that changing the signature for the ct_token_map function should be fully backwards compatible,

  1. it adds no additional generic types so turbofish should still work the same.
  2. Because of the following blanket trait impl it should still accept all &HashMap<String, Storaget> instances.
    https://doc.rust-lang.org/stable/std/borrow/trait.Borrow.html#impl-Borrow%3CT%3E-for-%26T

Thus my belief is that this just relaxes the type signature to allow additional parameters like Box or Rc without having to first convert it to a reference type.

@ltratt ltratt added this pull request to the merge queue May 22, 2025
Merged via the queue into softdevteam:master with commit b1d0af5 May 22, 2025
2 checks passed
@ratmice ratmice deleted the borrow_ct_token_map branch May 22, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants