Update nimbleparse help text regarding default values #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratmice
commented
May 25, 2025
| "r", | ||
| "recoverer", | ||
| "Recoverer to be used (default: cpctplus)", | ||
| "Recoverer to be used (default: cpctplus unless specified in grammar)", |
Collaborator
Author
There was a problem hiding this comment.
This text could perhaps be more leading towards the user finding how to specify it.
E.g. "unless specified in the %grmtools section of the grammar", but I feared making it too long
and I don't see any obvious way it gets printed, so I stuck with "unless specified in the grammar"
which is already way longer than the current text.
Member
|
I don't think you can get these printed out, but having them be less misleading in the source is a worthwhile goal in and of itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had missed/failed to notice that in nimbleparse there is some help text regarding default values.
This missed getting updated when the default values were changed with the
%grmtoolssection changes.I'm not actually certain how to get this text to print from nimbleparse, as things like
-y list, etc didn't seem to work.But I also didn't dig at all into the getopt crate, and the changes seemed straightforward enough.