Replace usage of lazy_static with LazyLock.
#587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove the dependency on `lazy_static` since `LazyLock` is provided by `std`. Since `lazy_static` can obscure linting of unused variables some unused values could be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove the dependency on
lazy_staticsinceLazyLockis provided bystd. Sincelazy_staticcan obscure linting of unused variables some unused values could also be removed.LazyLock was stabilized in 1.80, (older than the 1.85 required by bincode)
so this seemed like an improvement to me as it keeps much the same code structure, and since it
implements
Derefit seems like we don't even need to change any call sites.