Allow using generics with %parse-param
#590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taminomara
force-pushed
the
generic-params
branch
2 times, most recently
from
93119d1 to
23007f4
Compare
Member
|
This looks good to me. @ratmice, any comments? |
Collaborator
|
I've been a bit preoccupied so my analysis isn't going to be particularly deep. The only thing I noticed is it'd be good to rewrite the commit message which still references |
This commit adds a new directive `%parse-generics`, which allows passing arbitrary generics (types and lifetimes) to the generated parser implementation. The generics are propagated to action functions and `__GtActionsKind`, so they're available in return types as well. This change only affects generated code: generics are not propagated to parser backend. I've also added an example with my use case: passing an arena allocator, and returning references to AST nodes.
taminomara
force-pushed
the
generic-params
branch
from
23007f4 to
ab1d07d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new directive
%parse-generics, which allows passing arbitrary generics (types and lifetimes) to the generated parser implementation.The generics are propagated to action functions and
__GtActionsKind, so they're available in return types as well.This change only affects generated code: generics are not propagated to parser backend.
I've also added an example with my use case: passing an arena allocator, and returning references to AST nodes.