Reserve test_files extensions starting with grm
#596
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reserves
test_filesfrom the%grmtoolswhich have a file extension beginning with.grmThis is regarding #595 (comment)
So we can delay #593 to a future release, and not hold this one up on that, but do so compatibly.
I tested this manually by setting the
test_filessection of calc_astfrom
test_files: "input*.txt"totest_files: "input*", then adding acalc_ast/src/input.grmfoofile,Then manually ran
cargo buildandnimbleparse src/calc.{l,y}This succeeded when the
input.grmfoofile was gone, and failed with the appropriate error when it was there.