Skip to content

Remove FinalizerSafe trait #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ltratt merged 1 commit into from
Dec 2, 2024
Merged

Remove FinalizerSafe trait #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ pub fn narrowable_alloy(args: TokenStream, input: TokenStream) -> TokenStream {
unsafe impl<U: Send> Send for #struct_union_id<U> {}
unsafe impl<U: Sync> Sync for #struct_union_id<U> {}

unsafe impl<U: FinalizerSafe> FinalizerSafe for #struct_union_id<U> {}
unsafe impl<U> ::std::gc::DropMethodFinalizerElidable for #struct_union_id<U> {}

impl<U> ::std::ops::Drop for #struct_union_id<U> {
Expand Down Expand Up @@ -231,9 +230,9 @@ pub fn narrowable_alloy(args: TokenStream, input: TokenStream) -> TokenStream {
let vtable = unsafe { ::std::mem::transmute::
<*const dyn #trait_id, (*const u8, *const u8)>(&obj) }
.1;
let gc = ::std::gc::Gc::new(#struct_union_id {
let gc = unsafe { ::std::gc::Gc::new(::std::gc::FinalizeUnchecked::new(#struct_union_id {
long: ::std::mem::ManuallyDrop::new(#struct_long_id { vtable, obj })
});
}))};
unsafe {
::std::gc::Gc::from_raw(&*gc.short as *const Self)
}
Expand Down