Skip to content

Conversation

@ratmice
Copy link
Collaborator

@ratmice ratmice commented Mar 17, 2025

In the second patch, using MIN/MAX I believe these all occur within, because it only appeared with cargo clippy --all-targets.

@ltratt ltratt added this pull request to the merge queue Mar 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 17, 2025
@ratmice
Copy link
Collaborator Author

ratmice commented Mar 17, 2025

Formatting error, will need a squash.

@ratmice
Copy link
Collaborator Author

ratmice commented Mar 17, 2025

Oh, I also meant to mention there are a few places where this uses T::min_value() and T::max_value() still.
Unfortunately there doesn't appear to be a num_traits trait with the appropriate associated consts

@ltratt
Copy link
Member

ltratt commented Mar 17, 2025

Please squash.

Oh, I also meant to mention there are a few places where this uses T::min_value() and T::max_value() still. Unfortunately there doesn't appear to be a num_types trait with the appropriate associated consts

C'est la vie, I suppose!

@ratmice
Copy link
Collaborator Author

ratmice commented Mar 17, 2025

Squashed.

@ratmice ratmice mentioned this pull request Mar 17, 2025
@ltratt ltratt added this pull request to the merge queue Mar 17, 2025
Merged via the queue into softdevteam:master with commit 7074873 Mar 17, 2025
2 checks passed
@ratmice ratmice deleted the clippy branch March 17, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants