Merged
Conversation
Build and run tests for both crypto backends on Linux, and currently just build without tests on Windows.
Fixed CMake issues to be able to build tests on Windows, and added a test step to Github Actions CI.
Contributor
Author
|
If accepted I can update this PR with a build status badge on the README.md, |
Build and run tests for both crypto backends on macOS in CI. Mac/OS X is supported since it is documented in OSX-NOTES.md
Contributor
Author
|
Added so we also build and run tests on Mac/OSX which is supported according to OSX-NOTES.md. |
Contributor
|
I believe this would be a great update to the CI workflow. |
jschlyter
approved these changes
Feb 5, 2024
Contributor
|
Can you refresh this PR and I'll merge it. |
|
Could I suggest building against latest OpenSSL 1.1.1 version, which is 1.1.1w ? |
Contributor
Let's start with the current setup on pure Ubuntu 20.04 and take it from there. I'd be happy to merge updates for various OpenSSL version later (and we need to once support for OpenSSL 3.x is merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Travis CI is no longer free as before, and there are issues with AppVeyor we currently don't have a working CI.
This PR adds a basic CI run which build and run tests for both crypto backends on Linux, Mac and Windows.
An example run: https://github.com/Nordix/SoftHSMv2/actions/runs/7718456304
The failed botan run is related to #724
Windows vcpkg's are cached for faster builds, but there are a lot of other improvements that could be done to this CI.
Examples are running sanitizers/valgrind/Coverity on Linux or using later OpenSSL version.
In general we would like to support this project, and adding a CI which can indicate existing issues is a start.
WDYT @halderen @rijswijk @jschlyter ?