Skip to content

Conversation

@middagj
Copy link
Contributor

@middagj middagj commented Nov 27, 2024

macOS uses .dylib and this is the only thing that prevents using CMake on macOS.

@jschlyter
Copy link
Contributor

Can you rebase on develop so we test results?

@jschlyter jschlyter self-assigned this Nov 29, 2024
@jschlyter jschlyter added the small Small PR label Nov 29, 2024
@middagj middagj requested a review from a team as a code owner November 29, 2024 12:04
@middagj
Copy link
Contributor Author

middagj commented Nov 29, 2024

Can you rebase on develop so we test results?

Done

macOS uses .dylib and this is the only thing that prevents using CMake on macOS.
@bjosv
Copy link
Contributor

bjosv commented Nov 29, 2024

Nice. We could add CMake builds in CI for both Linux and Mac when this is merged then.

@jschlyter jschlyter merged commit 519f7a5 into softhsm:develop Nov 29, 2024
3 of 7 checks passed
@middagj middagj deleted the cmake-macos branch November 29, 2024 15:04
@middagj
Copy link
Contributor Author

middagj commented Nov 29, 2024

Thanks, I wasn't expecting this quick merge actually. There is another thing that is not helping with macOS (and probably Linux as well). But let me put that in another PR.

@middagj
Copy link
Contributor Author

middagj commented Nov 29, 2024

Never mind, I guess I am just running into the issue that install require relative dirs but GNUInstallDirs has absolute paths. Probably the reason why in this project the CMAKE_INSTALL_SYSCONFDIR and CMAKE_INSTALL_LOCALSTATEDIR are set to absolute values (which is not recommended).

The reporter created some alternative you might want to add.

Anyways, this is now how I configure:

cmake -H. -Bbuild \
    -DCMAKE_INSTALL_PREFIX=$INSTALL_DIR \
    -DCMAKE_INSTALL_SYSCONFDIR=$INSTALL_DIR/etc \
    -DCMAKE_INSTALL_LOCALSTATEDIR=$INSTALL_DIR/var

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small Small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants