fix(Game): do not send repeated MoveRequests

Author: xeruf

.dev/scopes.txt

@@ -18,3 +18,4 @@ sdk
 framework
 network
 logging
+Game

plugin/src/main/kotlin/sc/plugin2022/Game.kt

@@ -136,7 +136,6 @@ class Game(override val currentState: GameState = GameState()): AbstractGame(Gam
 
         logger.debug("Performing $move")
         currentState.performMove(move)
-        next()
         logger.debug("Current State: ${currentState.longString()}")
     }
 

sdk/src/main/server-api/sc/framework/plugins/AbstractGame.kt

@@ -7,9 +7,9 @@ import sc.api.plugins.IMove
 import sc.api.plugins.exceptions.GameLogicException
 import sc.api.plugins.exceptions.NotYourTurnException
 import sc.api.plugins.host.IGameListener
+import sc.protocol.room.WelcomeMessage
 import sc.shared.InvalidMoveException
 import sc.shared.PlayerScore
-import sc.protocol.room.WelcomeMessage
 import sc.shared.WinCondition
 
 abstract class AbstractGame(override val pluginUUID: String) : IGameInstance, Pausable {
@@ -29,7 +29,7 @@ abstract class AbstractGame(override val pluginUUID: String) : IGameInstance, Pa
     /** Pause the game after current turn has finished or continue playing. */
     override var isPaused = false
         set(value) {
-            if(!value)
+            if(!value && moveRequestTimeout == null)
                 step()
             field = value
         }
@@ -55,6 +55,7 @@ abstract class AbstractGame(override val pluginUUID: String) : IGameInstance, Pa
         if (fromPlayer != activePlayer)
             throw NotYourTurnException(activePlayer, fromPlayer, move)
         moveRequestTimeout?.let { timer ->
+            moveRequestTimeout = null
             timer.stop()
             logger.info("Time needed for move: " + timer.timeDiff)
             if (timer.didTimeout()) {
@@ -63,6 +64,7 @@ abstract class AbstractGame(override val pluginUUID: String) : IGameInstance, Pa
                 stop()
             } else {
                 onRoundBasedAction(move)
+                next()
             }
         } ?: throw GameLogicException("Move from $fromPlayer has not been requested.")
     }

server/src/test/java/sc/server/plugins/TestGame.kt

@@ -25,7 +25,6 @@ data class TestGame(
                 override val message = "TestGame only processes TestMove"
             })
         move.perform(currentState)
-        next()
     }
 
     override fun checkWinCondition(): WinCondition? {