chore: Remove the deprecated asUsage api
#1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated asUsage API functions (asMutable, asReadonly, asUniform) that were previously marked as deprecated. The functions have been renamed to simpler names (mutable, readonly, uniform) and the old test file has been deleted with its tests consolidated into the main buffer usage test file.
- Renamed deprecated buffer usage functions to shorter names
- Removed deprecated JSDoc annotations and updated error messages
- Consolidated test coverage by moving tests from
asUsage.test.tsintobufferUsage.test.ts
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/typegpu/src/core/buffer/bufferUsage.ts | Renamed asMutable, asReadonly, asUniform to mutable, readonly, uniform; removed deprecation comments and updated error messages |
| packages/typegpu/src/core/buffer/buffer.ts | Updated imports to use the new function names |
| packages/typegpu/tests/asUsage.test.ts | Deleted the entire test file as part of consolidation |
| packages/typegpu/tests/bufferUsage.test.ts | Added tests for buffer usage validation that were previously in the deleted file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aleksanderkatan
requested review from
cieplypolar,
iwoplaza,
lursz and
reczkok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API was used internally, and wasn't exposed, so there wasn't much to do.