Draft
Conversation
piotmag769
commented
Feb 16, 2026
Comment on lines
+10
to
+12
| cairo-lang-sierra = "=2.12.3" | ||
| cairo-lang-sierra-to-casm = "=2.12.3" | ||
| cairo-lang-casm = "=2.12.3" |
Collaborator
Author
There was a problem hiding this comment.
I pin to the same version snforge does to see cargo resolver errors as early as possible 🤷
Collaborator
Author
There was a problem hiding this comment.
This is really ugly and I will rework it together with #35 (this way we can get rid of the Option - there is no vm during initialization)
piotmag769
commented
Feb 17, 2026
src/debugger/call_stack.rs
Outdated
| // TODO(#16) | ||
| .zip(iter::repeat_with(|| FunctionVariables {})) | ||
| // ctx.get_values_of_variables(statement_idx, vm), | ||
| .zip(iter::repeat_with(FunctionVariables::default)) |
Collaborator
Author
There was a problem hiding this comment.
We should construct FunctionVariables for each StackFrame, but currently we don't care about inlining (we are fine with the logic being wrong if there are more frames than 1 in a substack) since:
- We are in MVP stage.
- Only cases where inlining is present are
#[inline(always)]cases and they are rare (user can always comment out the attribute if they want to debug such a function).
To handle inlines, do as follows:
- Complete Handle inline locations when producing sierra function debug info (compiler side) #41 first.
- When creating
FunctionVariableswhen we are on the given statement, we would still be, from sierra POV, in a body of a ONE function which may contain bodies of OTHER function that were inlined. For each statement from beginning of the function to the current statement: compare profiler mappings and current sierra call stack to tell if a statement is a part of inlined function body or "real" function body. Then based on that, assign the variable value to the proper function (so we would in fact returnVec<FunctionVariables>).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.