Skip to content

Conversation

@srzeszut
Copy link
Contributor

@srzeszut srzeszut commented Oct 29, 2025

No description provided.

@srzeszut srzeszut force-pushed the debugging-streams-with-streams branch from a31e21c to f74f500 Compare October 29, 2025 23:01
@srzeszut srzeszut force-pushed the debugging-streams-with-streams branch from 54e1c91 to 4899f2e Compare November 3, 2025 12:29
@srzeszut srzeszut marked this pull request as ready for review November 3, 2025 17:40
@srzeszut srzeszut requested review from hhubert6 and kraleppa November 3, 2025 17:40
Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I add some initial elements to the stream they are not displayed

Image

It'd be best to add that case to the e2e tests as well.

@srzeszut
Copy link
Contributor Author

srzeszut commented Nov 6, 2025

When I add some initial elements to the stream they are not displayed

Image It'd be best to add that case to the e2e tests as well.

Sorry, my bad. I forgot about the case where stream diffs don't include the updated? field. I'll add an e2e test for the initial elements.

@srzeszut srzeszut requested a review from hhubert6 November 6, 2025 12:20
@kraleppa kraleppa linked an issue Nov 13, 2025 that may be closed by this pull request
@srzeszut srzeszut requested a review from kraleppa November 18, 2025 08:09
Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🔥

Copy link
Member

@kraleppa kraleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-11-21 at 13 41 52

Can you make this padding to be the same on left and right? It should just px-4

Copy link
Member

@kraleppa kraleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👏

Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🔥

@srzeszut srzeszut merged commit 4dd6772 into main Nov 26, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debugging streams

4 participants