Refactor: update tracing action buttons #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kraleppa
reviewed
Nov 17, 2025
Member
kraleppa
left a comment
kraleppa
left a comment
There was a problem hiding this comment.
The space on the right to stop/dropdown button is smaller when tracing is started than in a case when it's stopped
They should be the same everytime (and correct size is when tracing is started)
lib/live_debugger/app/debugger/callback_tracing/web/components/trace_settings.ex
Outdated
Show resolved
Hide resolved
lib/live_debugger/app/debugger/callback_tracing/web/components/trace_settings.ex
Outdated
Show resolved
Hide resolved
lib/live_debugger/app/debugger/callback_tracing/web/hook_components/filters_fullscreen.ex
Outdated
Show resolved
Hide resolved
kraleppa
reviewed
Nov 17, 2025
lib/live_debugger/app/debugger/callback_tracing/web/hook_components/clear_button.ex
Outdated
Show resolved
Hide resolved
kraleppa
approved these changes
Nov 18, 2025
Member
There was a problem hiding this comment.
Good job only some nitpicks - fix them and we're ready to merge
- Fullscreen button is missing a tooltip (it's the only action button that does not have a tooltip)
- There is some inconsitence in case of action buttons. E.g. dropdown button has slightly bigger height that start/stop button - check the photo below. They should be identical squares
lib/live_debugger/app/debugger/callback_tracing/web/hook_components/toggle_tracing_button.ex
Outdated
Show resolved
Hide resolved
hhubert6
reviewed
Nov 19, 2025
srzeszut
force-pushed
the
825-update-action-buttons
branch
from
ac164be to
506b382
Compare
kraleppa
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.